On 05/31/2010 01:09 PM, Christoph Hellwig wrote: > Various odd things going on here: > > - no checks for I_DIRTY and friends, so it will always write out data > - filemap_write_and_wait is superflous, as it's already done by > the caller > - write_inode_now is overkill as it also writes out data, better use > sync_inode in a similar way to generic_file_fsync I'll look into it, but I think what I did here was to effectively "data sync" because I wanted a data sync on close and that was the only vector I already had that's called on close. I want "data sync on close" because I'm kind of close-2-open network semantics, cross a network. And this is my local access checkpoint. But sure I'll re think the all thing. Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
