On 05/30/2010 11:49 PM, Christoph Hellwig wrote: > This series is something that I see as the first major step towards > a broad switch to the new truncate sequence. The patches get rid > of the _newtrunc variant of blockdev_direct_IO & friends and > *_write_begin, and clean up some bits in that area that make the > switch easier. After this we have all vmtruncate instances except > for inode_setattr in filesystem code. A second series to deal > with ->setattr will follow and after that we can easily switch > over one filesystem after another. > > I think this is still 2.6.34 material as it will make the fs > switches a lot easier and avoid introducing the _newtrunc variants > for one kernel release. > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html Christoph, Nick hi. I'm attempting a truncate conversion for exofs, will need a review. I'm basing the first attempt on Al's next tree that has Nicks last patches. Will rebase on these when they get into that tree. Please advise on the best tree to use? (BTW did you mean 2.6.35 above, I guess) So one minor thing ext2_setsize can be static: (It used to be used by the struct inode_operations) --- git diff --stat -p -M fs/ext2/inode.c fs/ext2/inode.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 1921443..c8ae0da 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -1169,7 +1169,7 @@ static void ext2_truncate_blocks(struct inode *inode, loff_t offset) __ext2_truncate_blocks(inode, offset); } -int ext2_setsize(struct inode *inode, loff_t newsize) +static int ext2_setsize(struct inode *inode, loff_t newsize) { loff_t oldsize; int error; -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
