On Fri, May 28, 2010 at 5:40 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > On Wed, 26 May 2010, Changli Gao wrote: >> remove flags paramter of do_splice_direct(). >> >> the flags parameter of do_splice_direct() doesn't mean non-block read of >> in file, > > Actually, it does. Look at the SPLICE_F_NONBLOCK usage in > __generic_splice_file_read(). > Oh, I checked the code again. You're right. However, why don't we check the flags of in file instead in __generic_file_splice_read()? -- Regards， Changli Gao(xiaosuo@xxxxxxxxx) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
