On 03/25/2010 03:37 PM, Al Viro wrote: > On Thu, Mar 25, 2010 at 03:30:22PM +0200, Boaz Harrosh wrote: >>> Let's try this: before do_lookup() call there add >>> if (*want_dir) >>> nd->flags |= LOOKUP_DIRECTORY; >> >> Yes this fixes it!! >> 2.6.34-rc2 plus above, now works, horay. (diff attached) >> >>> and see how does it behave. >>> >>> However, even if it does help, it doesn't explain everything. Normal >>> open() on a directory without O_DIRECTORY if flags shouldn't fail with >>> -EISDIR. How did that manage to avoid it all along? > > Does open() of directory _without_ O_DIRECTORY work in e.g. vanilla 2.6.33? > It certainly does for local filesystems and it does for NFSv3; does it work > for NFSv4? In my tests. Every thing is the same safe the client with the above change. So I guess NFSv4 does something different when asked for directory lookup as opposed to files lookup. I guess there is something added/removed to the compound depending on that flag. But I wouldn't know, I am not familiar with this code. NFSv4 someone? Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
