Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to use of do_last()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mar. 25, 2010, 12:54 +0200, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Mar 25, 2010 at 10:12:31AM +0000, Al Viro wrote:
>> On Thu, Mar 25, 2010 at 11:39:38AM +0200, Boaz Harrosh wrote:
>>
>>> It makes no difference, fails just the same. Would an "strace" help?
>> It might, especially if you ran it for identical repositories on local
>> fs and on NFS; at least that way it would be possible to see where do
>> they diverge...
> 
> I wonder...  What happens if you add
> 	if (error == -EISDIR)
> 		printk("blah: %s", pathname);
> right after do_lookup() call in do_last()?  That would separate -EISDIR
> coming from NFS from the same thing coming from fs/namei.c...

Bingo.
It is returned from do_lookup.

@@ -1648,6 +1654,8 @@ static struct file *do_last(struct nameidata *nd, struct path *path,
 	/* just plain open? */
 	if (!(open_flag & O_CREAT)) {
 		error = do_lookup(nd, &nd->last, path);
+		if (error == -EISDIR)
+			printk("%s: do_lookup returned -EISDIR %s\n", __func__, pathname);
 		if (error)
 			goto exit;
 		error = -ENOENT;


> _______________________________________________
> pNFS mailing list
> pNFS@xxxxxxxxxxxxx
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux