On Tue 02-03-10 14:50:40, Christoph Hellwig wrote: > On Tue, Mar 02, 2010 at 07:44:38PM +0100, Jan Kara wrote: > > I've looked at the patch. I have several comments: > > It seems that conversion of UDF is completely missing from the patch. > > Indeed. UDF also got left out at least from the dquot transfer patch > which should have added one to it. Do you want me to respin those > patches to include udf? Yes, please respin dquot_transfer patches and dquot_drop seems to also have the problem so those ones as well. > > Also it seems that UFS is missing conversion of ufs_setattr to call > > vfs_dq_init when ATTR_SIZE is set. > > Indeed. I'm pretty sure I did these, but can't find them in my patch > anymore. Probably got lost to some quilt interaction. > > > Finally, ocfs2 is missing conversion > > of ocfs2_open so that it calls vfs_dq_init. > > ocfs2 calls vfs_dq_init manually. Ah, my fault, now I see it in the patch. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html