On Tue, Mar 02, 2010 at 07:44:38PM +0100, Jan Kara wrote:
> I've looked at the patch. I have several comments:
> It seems that conversion of UDF is completely missing from the patch.
Indeed. UDF also got left out at least from the dquot transfer patch
which should have added one to it. Do you want me to respin those
patches to include udf?
> Also it seems that UFS is missing conversion of ufs_setattr to call
> vfs_dq_init when ATTR_SIZE is set.
Indeed. I'm pretty sure I did these, but can't find them in my patch
anymore. Probably got lost to some quilt interaction.
> Finally, ocfs2 is missing conversion
> of ocfs2_open so that it calls vfs_dq_init.
ocfs2 calls vfs_dq_init manually.
> > +++ linux-2.6/fs/ocfs2/file.c 2010-02-20 12:00:45.648255722 +0100
> > @@ -976,6 +979,9 @@ int ocfs2_setattr(struct dentry *dentry,
> > if (status)
> > return status;
> >
> > + if (attr->ia_valid & ATTR_SIZE)
> > + vfs_dq_init(inode);
> > +
> > size_change = S_ISREG(inode->i_mode) && attr->ia_valid & ATTR_SIZE;
> > if (size_change) {
> > status = ocfs2_rw_lock(inode, 1);
> We can merge the above two conditions...
Ok.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
