On Wed 24-02-10 17:26:37, Camille Moncelier wrote: > > Theoretically some pages may exist after rw=>ro remount > > because of generic race between write/sync, And they will be written > > in by writepage if page already has buffers. This not happen in ext4 > > because. Each time it try to perform writepages it try to start_journal > > and this result in EROFS. > > The race bug will be closed some day but new one may appear again. > > > > Let's be honest and change ext3 writepage like follows: > > - check ROFS flag inside write page > > - dump writepage's errors. > > > > > I think I don't understand correctly your patch. For me it seems that > when an ext3 filesystem is remounted ro, some data may not have been > written to disk right ? I think that Dmitry was concerned about the fact that a process could open a file and write to it after we synced the filesystem in do_remount_sb(). Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
