On Thu, Mar 13, 2025 at 01:53:59PM +0000, Matthew Wilcox wrote: > On Mon, Feb 03, 2025 at 10:43:07AM +0100, Christoph Hellwig wrote: > > Allocate the bio from the bioset provided in iomap_read_folio_ops. > > If no bioset is provided, fs_bio_set is used which is the standard > > bioset for filesystems. > > It feels weird to have an 'ops' that contains a bioset rather than a > function pointer. Is there a better name we could be using? ctx seems > wrong because it's not a per-op struct. As Darrick pointed out ops commonly have non-method static fields of some kind. After at all it still mostly is about ops, the bio_set pointer just avoids having to add a special alloc indirection that will all end up using the same code just with a different bio_set.
