On Wed, Mar 12, 2025 at 06:40:53AM +0100, Christoph Hellwig wrote: > On Tue, Mar 11, 2025 at 10:37:27PM -0700, Luis Chamberlain wrote: > > > If you need extra per-driver validatation, do it in the driver. > > > > Are you suggesting we just move back the PAGE_SIZE check, > > PAGE_SIZE now is a consumer (i.e. file system) limitation. Having > a flag in the provider (driver) does not make sense. > > > or to keep > > the checks for the block driver limits into each driver? > > Most drivers probably don't have a limit other than than that implicit > by the field width used for reporting. So in general the driver should > not need any checks. The only exceptions might be for virtual drivers > where the value comes from userspace, but even then it is a bit doubtful. Alrighty, so silly tests just need to be updated. If a hang is reported, we can look into it, or just add block driver checks / limitations. Luis
