On Tue, 26 Jan 2010 23:44:29 -0200 Thiago Farina <tfransosi@xxxxxxxxx> wrote: > > It is somewhat unconventional coding style and it'd be good if > > checkpatch were to warn so that we don't _add_ such things to the tree. > > > > But IMO it's such a minor thing that once it _is_ in the tree, it's not > > really worth the patch noise to go and fix it up. > > Yeah, much noise for a small thing. I will not fix more warnings like > this in future. I'd be OK with fixing things like this as part of a larger "fs/binfmt_elf.c: coding-style fixes" or "fs/*elf.c: ...", etc. One big hit. It's the little dribble of one-line fixes which I'd prefer to avoid. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html