> + /* please add new bits here to ensure allocation uniqueness */ > + BUG_ON(20 != hweight32( > + O_RDONLY | O_WRONLY | O_RDWR | I wonder if there's a way to make this BUILD_BUG_ON(), so the problem is caught at compile time (a change like adding an O_ flag is often compile tested only for obscure archs). One could create a compile-time macro-ized version of hweight32() and use that, I guess, although I'm not sure it's worth the ugliness. Failing that maybe this should be WARN_ON()? I'd be annoyed if my arch wouldn't boot because some strange new O_ flag happened to collide. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
