On Thu, 17 Dec 2009 10:31:52 +0200 Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote: > Can we please revert commit e4c570c4cb7a95dbfafa3d016d2739bf3fdfe319 > "task_struct: make journal_info conditional" > > I think I gave a good enough arguments to not merge it. > To iterate: > * patch makes impossible to start using ext3 on EXT3_FS=n kernels > without reboot. > * this is done only for one pointer on task_struct > > None of config options which define task_struct are tristate directly > or effectively. > > There are other examples where we don't do this: > * quota stuff on superblock aren't ifdeffed because of modular XFS > with quota support. > * exports operations and s_anon for NFS > and so on Confused. I "dropped" that patch when you pointed out the problem then forgot about it. Maybe I dropped something else by accident. argh. I agree - I'll queue a revert. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html