On Mon, 11 Nov 2024 at 14:29, Christian Brauner <brauner@xxxxxxxxxx> wrote: > I understand your frustation but multiple people agreed that the > interface as is is fine and Karel as main consumer agreed as well. So > ultimately I didn't see a reason to delay the patchset. This was actually in the first versions that I sent out, but then was removed per your request. Then Josef's crufty version added back. Yeah, for libmount it's fine, but the de-crufted version would've been alright as well. Oh, well... > None of the issues you raised are really things that make the interface > uncomsumable and Karel succeeded to port libmount to the new interfaces > with success (minus the mnt_devname we're adding now that he requested) > and was happy. The problem is with non-libmount users. They won't implement unescaping until they run into trouble. And that will be too late because these cases are rare. > If there's genuine behavioral problems that cause substatntial issues > for userspace then I would request that you please add a new flag that > changes escaping and parsing behavior for statmount(). Need to take a look at what this now does to overlayfs filenames with commas and other special chars in them and see if it can be salvaged. Thanks, Miklos
