On 10/3/24 16:04, Miklos Szeredi wrote: > On Thu, 3 Oct 2024 at 16:02, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: >> >> On Thu, 3 Oct 2024 at 15:56, Bernd Schubert <bernd.schubert@xxxxxxxxxxx> wrote: >> >>> I'm inclined to do xarray, but still to assign an index (in the order of >>> received FUSE_URING_REQ_FETCH per queue) - should still give O(1). >> >> xarray index is unsigned long, while req->unique is u64, which on 32 >> bit doesn't fit. > > I suggest leaving this optimization to a later time. Less code to > review and less chance for bugs to creep in. Well, we need to search - either rbtree or xarray, please not the existing request_find() with a list search - totally unsuitable for large number of requests in fly (think of a ring with 32768 entries). I.e. that points to not using req->unique, but own own index. Thanks, Bernd
