On Mon, Sep 2, 2024 at 10:02 AM Christian Brauner <brauner@xxxxxxxxxx> wrote: > > On Thu, Aug 08, 2024 at 04:15:43PM GMT, Alice Ryhl wrote: > > This patchset contains the file abstractions needed by the Rust > > implementation of the Binder driver. > > > > Please see the Rust Binder RFC for usage examples: > > https://lore.kernel.org/rust-for-linux/20231101-rust-binder-v1-0-08ba9197f637@xxxxxxxxxx/ > > > > Users of "rust: types: add `NotThreadSafe`": > > [PATCH 5/9] rust: file: add `FileDescriptorReservation` > > > > Users of "rust: task: add `Task::current_raw`": > > [PATCH 7/9] rust: file: add `Kuid` wrapper > > [PATCH 8/9] rust: file: add `DeferredFdCloser` > > > > Users of "rust: file: add Rust abstraction for `struct file`": > > [PATCH RFC 02/20] rust_binder: add binderfs support to Rust binder > > [PATCH RFC 03/20] rust_binder: add threading support > > > > Users of "rust: cred: add Rust abstraction for `struct cred`": > > [PATCH RFC 05/20] rust_binder: add nodes and context managers > > [PATCH RFC 06/20] rust_binder: add oneway transactions > > [PATCH RFC 11/20] rust_binder: send nodes in transaction > > [PATCH RFC 13/20] rust_binder: add BINDER_TYPE_FD support > > > > Users of "rust: security: add abstraction for secctx": > > [PATCH RFC 06/20] rust_binder: add oneway transactions > > > > Users of "rust: file: add `FileDescriptorReservation`": > > [PATCH RFC 13/20] rust_binder: add BINDER_TYPE_FD support > > [PATCH RFC 14/20] rust_binder: add BINDER_TYPE_FDA support > > > > Users of "rust: file: add `Kuid` wrapper": > > [PATCH RFC 05/20] rust_binder: add nodes and context managers > > [PATCH RFC 06/20] rust_binder: add oneway transactions > > > > Users of "rust: file: add abstraction for `poll_table`": > > [PATCH RFC 07/20] rust_binder: add epoll support > > > > This patchset has some uses of read_volatile in place of READ_ONCE. > > Please see the following rfc for context on this: > > https://lore.kernel.org/all/20231025195339.1431894-1-boqun.feng@xxxxxxxxx/ > > > > Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx> > > --- > > So, this won't make v6.12 anymore. There already were pretty big changes > around files for the coming cycle so I did not also want to throw this > into the mix as well. (Sorry that this had to miss it's birthday, Alice.) This has also gained a conflict with the helpers split [1] in rust-next, so maybe that is for the best. I will look into whether any other changes are needed given what is going in for 6.12 and send a new version. It looks like you already added it to an vfs.rust.file branch, and it doesn't look like anything in vfs.file required changes in this series. [1]: https://lore.kernel.org/r/20240815103016.2771842-1-nmi@xxxxxxxxxxxx > However, I do intend to merge a version for this for v6.13. There's some > wrapping of struct cred and specifically of struct secctx that I can > only handwave at. Ideally you get a nod from the LSM maintainers as well > but if that doesn't come in I don't see much point in making this sit in > limbo indefinitely. Okay thanks! I can look into that. Alice