Re: [PATCH 02/11] fuse: convert fuse_send_write_pages to use folios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 27, 2024 at 10:53:58PM +0100, Matthew Wilcox wrote:
> On Tue, Aug 27, 2024 at 04:45:15PM -0400, Josef Bacik wrote:
> >  	for (i = 0; i < ap->num_pages; i++) {
> > -		struct page *page = ap->pages[i];
> > +		struct folio *folio = page_folio(ap->pages[i]);
> >  
> >  		if (err) {
> > -			ClearPageUptodate(page);
> > +			folio_clear_uptodate(folio);
> >  		} else {
> >  			if (count >= PAGE_SIZE - offset)
> >  				count -= PAGE_SIZE - offset;
> 
> I'd tend to adjust these to folio_size() while doing this function,
> just so that I don't have to come back to it later.
> 
> Either way,
> 
> Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

Same, I just glossed over this one because we weren't touching the folio
directly, I'll fix it up since I have to respin the series anyway.  Thanks,

Josef




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux