On Tue, Aug 27, 2024 at 04:45:15PM -0400, Josef Bacik wrote: > for (i = 0; i < ap->num_pages; i++) { > - struct page *page = ap->pages[i]; > + struct folio *folio = page_folio(ap->pages[i]); > > if (err) { > - ClearPageUptodate(page); > + folio_clear_uptodate(folio); > } else { > if (count >= PAGE_SIZE - offset) > count -= PAGE_SIZE - offset; I'd tend to adjust these to folio_size() while doing this function, just so that I don't have to come back to it later. Either way, Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>