On Tue, Aug 20, 2024 at 10:10:51AM GMT, Linus Torvalds wrote: > On Tue, 20 Aug 2024 at 09:07, Christian Brauner <brauner@xxxxxxxxxx> wrote: > > > > > > +struct wait_queue_head *inode_bit_waitqueue(struct wait_bit_queue_entry *wqe, > > + struct inode *inode, int bit); Bah, I sent from the wrong branch. This is the branch where I even forgot to remove that godforsaken ; at the end here... > > +{ > > + struct wait_queue_head *wq_head; > > + void *bit_address; > > + > > + bit_address = inode_state_wait_address(inode, __I_SYNC); > > Shouldn't that '__I_SYNC' be 'bit' instead? Yeah, that's also fixed on the work.i_state branch. I sent from work.i_state.wip... :/