Re: [viro-vfs:work.fdtable 13/13] kernel/fork.c:3242 unshare_fd() warn: passing a valid pointer to 'PTR_ERR'

[Al Viro <viro@xxxxxxxxxxxxxxxxxx>]

On Tue, Aug 13, 2024 at 11:00:04AM +0300, Dan Carpenter wrote:
> 3f4b0acefd818e Al Viro           2024-08-06  3240  		if (IS_ERR(*new_fdp)) {
> 3f4b0acefd818e Al Viro           2024-08-06  3241  			*new_fdp = NULL;
> 3f4b0acefd818e Al Viro           2024-08-06 @3242  			return PTR_ERR(new_fdp);
>                                                                                ^^^^^^^^^^^^^^^^
> 	err = PTR_ERR(*new_fdp);
> 	*new_fdp = NULL;
> 	return err;

Argh...  Obvious braino, but what it shows is that failures of that
thing are not covered by anything in e.g. LTP.  Or in-kernel
self-tests, for that matter...