tree: https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.fdtable head: 3f4b0acefd818ec43b68455994ac2bd5166c06ae commit: 3f4b0acefd818ec43b68455994ac2bd5166c06ae [13/13] dup_fd(): change calling conventions config: x86_64-randconfig-161-20240813 (https://download.01.org/0day-ci/archive/20240813/202408130945.I8wIAYBm-lkp@xxxxxxxxx/config) compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202408130945.I8wIAYBm-lkp@xxxxxxxxx/ smatch warnings: kernel/fork.c:3242 unshare_fd() warn: passing a valid pointer to 'PTR_ERR' vim +/PTR_ERR +3242 kernel/fork.c 60997c3d45d9a6 Christian Brauner 2020-06-03 3232 int unshare_fd(unsigned long unshare_flags, unsigned int max_fds, 60997c3d45d9a6 Christian Brauner 2020-06-03 3233 struct files_struct **new_fdp) cf2e340f4249b7 JANAK DESAI 2006-02-07 3234 { cf2e340f4249b7 JANAK DESAI 2006-02-07 3235 struct files_struct *fd = current->files; cf2e340f4249b7 JANAK DESAI 2006-02-07 3236 cf2e340f4249b7 JANAK DESAI 2006-02-07 3237 if ((unshare_flags & CLONE_FILES) && a016f3389c0660 JANAK DESAI 2006-02-07 3238 (fd && atomic_read(&fd->count) > 1)) { 3f4b0acefd818e Al Viro 2024-08-06 3239 *new_fdp = dup_fd(fd, max_fds); 3f4b0acefd818e Al Viro 2024-08-06 3240 if (IS_ERR(*new_fdp)) { 3f4b0acefd818e Al Viro 2024-08-06 3241 *new_fdp = NULL; 3f4b0acefd818e Al Viro 2024-08-06 @3242 return PTR_ERR(new_fdp); ^^^^^^^^^^^^^^^^ err = PTR_ERR(*new_fdp); *new_fdp = NULL; return err; 3f4b0acefd818e Al Viro 2024-08-06 3243 } a016f3389c0660 JANAK DESAI 2006-02-07 3244 } cf2e340f4249b7 JANAK DESAI 2006-02-07 3245 cf2e340f4249b7 JANAK DESAI 2006-02-07 3246 return 0; cf2e340f4249b7 JANAK DESAI 2006-02-07 3247 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki