Hi Mickaël, kernel test robot noticed the following build errors: [auto build test ERROR on pcmoore-selinux/next] [also build test ERROR on linus/master v6.11-rc3 next-20240812] [cannot apply to brauner-vfs/vfs.all] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Micka-l-Sala-n/fs-security-Fix-file_set_fowner-LSM-hook-inconsistencies/20240813-004648 base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next patch link: https://lore.kernel.org/r/20240812144936.1616628-1-mic%40digikod.net patch subject: [PATCH] fs,security: Fix file_set_fowner LSM hook inconsistencies config: i386-buildonly-randconfig-002-20240813 (https://download.01.org/0day-ci/archive/20240813/202408130919.naHeqbVw-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240813/202408130919.naHeqbVw-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202408130919.naHeqbVw-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): In file included from include/linux/rculist.h:11, from include/linux/dcache.h:8, from include/linux/fs.h:8, from include/uapi/linux/aio_abi.h:31, from include/linux/syscalls.h:82, from fs/fcntl.c:8: fs/fcntl.c: In function 'f_getowner_uids': >> fs/fcntl.c:250:50: error: invalid type argument of '->' (have 'struct fown_struct') 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~ include/linux/rcupdate.h:527:17: note: in definition of macro '__rcu_dereference_check' 527 | typeof(*p) *local = (typeof(*p) *__force)READ_ONCE(p); \ | ^ include/linux/rcupdate.h:747:28: note: in expansion of macro 'rcu_dereference_check' 747 | #define rcu_dereference(p) rcu_dereference_check(p, 0) | ^~~~~~~~~~~~~~~~~~~~~ fs/fcntl.c:250:21: note: in expansion of macro 'rcu_dereference' 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~~~~~~~~~~~~~~ >> fs/fcntl.c:250:50: error: invalid type argument of '->' (have 'struct fown_struct') 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~ include/linux/rcupdate.h:527:38: note: in definition of macro '__rcu_dereference_check' 527 | typeof(*p) *local = (typeof(*p) *__force)READ_ONCE(p); \ | ^ include/linux/rcupdate.h:747:28: note: in expansion of macro 'rcu_dereference_check' 747 | #define rcu_dereference(p) rcu_dereference_check(p, 0) | ^~~~~~~~~~~~~~~~~~~~~ fs/fcntl.c:250:21: note: in expansion of macro 'rcu_dereference' 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~~~~~~~~~~~~~~ In file included from <command-line>: >> fs/fcntl.c:250:50: error: invalid type argument of '->' (have 'struct fown_struct') 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~ include/linux/compiler_types.h:490:23: note: in definition of macro '__compiletime_assert' 490 | if (!(condition)) \ | ^~~~~~~~~ include/linux/compiler_types.h:510:9: note: in expansion of macro '_compiletime_assert' 510 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~~~~~~~~~~~~~~~~~ include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~~~~~~~~~~~~ include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type' 49 | compiletime_assert_rwonce_type(x); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/rcupdate.h:527:50: note: in expansion of macro 'READ_ONCE' 527 | typeof(*p) *local = (typeof(*p) *__force)READ_ONCE(p); \ | ^~~~~~~~~ include/linux/rcupdate.h:675:9: note: in expansion of macro '__rcu_dereference_check' 675 | __rcu_dereference_check((p), __UNIQUE_ID(rcu), \ | ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/rcupdate.h:747:28: note: in expansion of macro 'rcu_dereference_check' 747 | #define rcu_dereference(p) rcu_dereference_check(p, 0) | ^~~~~~~~~~~~~~~~~~~~~ fs/fcntl.c:250:21: note: in expansion of macro 'rcu_dereference' 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~~~~~~~~~~~~~~ >> fs/fcntl.c:250:50: error: invalid type argument of '->' (have 'struct fown_struct') 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~ include/linux/compiler_types.h:490:23: note: in definition of macro '__compiletime_assert' 490 | if (!(condition)) \ | ^~~~~~~~~ include/linux/compiler_types.h:510:9: note: in expansion of macro '_compiletime_assert' 510 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~~~~~~~~~~~~~~~~~ include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~~~~~~~~~~~~ include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type' 49 | compiletime_assert_rwonce_type(x); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/rcupdate.h:527:50: note: in expansion of macro 'READ_ONCE' 527 | typeof(*p) *local = (typeof(*p) *__force)READ_ONCE(p); \ | ^~~~~~~~~ include/linux/rcupdate.h:675:9: note: in expansion of macro '__rcu_dereference_check' 675 | __rcu_dereference_check((p), __UNIQUE_ID(rcu), \ | ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/rcupdate.h:747:28: note: in expansion of macro 'rcu_dereference_check' 747 | #define rcu_dereference(p) rcu_dereference_check(p, 0) | ^~~~~~~~~~~~~~~~~~~~~ fs/fcntl.c:250:21: note: in expansion of macro 'rcu_dereference' 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~~~~~~~~~~~~~~ >> fs/fcntl.c:250:50: error: invalid type argument of '->' (have 'struct fown_struct') 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~ include/linux/compiler_types.h:490:23: note: in definition of macro '__compiletime_assert' 490 | if (!(condition)) \ | ^~~~~~~~~ include/linux/compiler_types.h:510:9: note: in expansion of macro '_compiletime_assert' 510 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~~~~~~~~~~~~~~~~~ include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~~~~~~~~~~~~ include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type' 49 | compiletime_assert_rwonce_type(x); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/rcupdate.h:527:50: note: in expansion of macro 'READ_ONCE' 527 | typeof(*p) *local = (typeof(*p) *__force)READ_ONCE(p); \ | ^~~~~~~~~ include/linux/rcupdate.h:675:9: note: in expansion of macro '__rcu_dereference_check' 675 | __rcu_dereference_check((p), __UNIQUE_ID(rcu), \ | ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/rcupdate.h:747:28: note: in expansion of macro 'rcu_dereference_check' 747 | #define rcu_dereference(p) rcu_dereference_check(p, 0) | ^~~~~~~~~~~~~~~~~~~~~ fs/fcntl.c:250:21: note: in expansion of macro 'rcu_dereference' 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~~~~~~~~~~~~~~ >> fs/fcntl.c:250:50: error: invalid type argument of '->' (have 'struct fown_struct') 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~ include/linux/compiler_types.h:490:23: note: in definition of macro '__compiletime_assert' 490 | if (!(condition)) \ | ^~~~~~~~~ include/linux/compiler_types.h:510:9: note: in expansion of macro '_compiletime_assert' 510 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~~~~~~~~~~~~~~~~~ include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~~~~~~~~~~~~ include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type' 49 | compiletime_assert_rwonce_type(x); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/rcupdate.h:527:50: note: in expansion of macro 'READ_ONCE' 527 | typeof(*p) *local = (typeof(*p) *__force)READ_ONCE(p); \ | ^~~~~~~~~ include/linux/rcupdate.h:675:9: note: in expansion of macro '__rcu_dereference_check' 675 | __rcu_dereference_check((p), __UNIQUE_ID(rcu), \ | ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/rcupdate.h:747:28: note: in expansion of macro 'rcu_dereference_check' 747 | #define rcu_dereference(p) rcu_dereference_check(p, 0) | ^~~~~~~~~~~~~~~~~~~~~ fs/fcntl.c:250:21: note: in expansion of macro 'rcu_dereference' 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~~~~~~~~~~~~~~ >> fs/fcntl.c:250:50: error: invalid type argument of '->' (have 'struct fown_struct') 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~ include/linux/compiler_types.h:490:23: note: in definition of macro '__compiletime_assert' 490 | if (!(condition)) \ | ^~~~~~~~~ include/linux/compiler_types.h:510:9: note: in expansion of macro '_compiletime_assert' 510 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert' 36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \ | ^~~~~~~~~~~~~~~~~~ include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type' 49 | compiletime_assert_rwonce_type(x); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/rcupdate.h:527:50: note: in expansion of macro 'READ_ONCE' 527 | typeof(*p) *local = (typeof(*p) *__force)READ_ONCE(p); \ | ^~~~~~~~~ include/linux/rcupdate.h:675:9: note: in expansion of macro '__rcu_dereference_check' 675 | __rcu_dereference_check((p), __UNIQUE_ID(rcu), \ | ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/rcupdate.h:747:28: note: in expansion of macro 'rcu_dereference_check' 747 | #define rcu_dereference(p) rcu_dereference_check(p, 0) | ^~~~~~~~~~~~~~~~~~~~~ fs/fcntl.c:250:21: note: in expansion of macro 'rcu_dereference' 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~~~~~~~~~~~~~~ >> fs/fcntl.c:250:50: error: invalid type argument of '->' (have 'struct fown_struct') 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~ include/linux/compiler_types.h:466:27: note: in definition of macro '__unqual_scalar_typeof' 466 | _Generic((x), \ | ^ include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE' 50 | __READ_ONCE(x); \ | ^~~~~~~~~~~ include/linux/rcupdate.h:527:50: note: in expansion of macro 'READ_ONCE' 527 | typeof(*p) *local = (typeof(*p) *__force)READ_ONCE(p); \ | ^~~~~~~~~ include/linux/rcupdate.h:675:9: note: in expansion of macro '__rcu_dereference_check' 675 | __rcu_dereference_check((p), __UNIQUE_ID(rcu), \ | ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/rcupdate.h:747:28: note: in expansion of macro 'rcu_dereference_check' 747 | #define rcu_dereference(p) rcu_dereference_check(p, 0) | ^~~~~~~~~~~~~~~~~~~~~ fs/fcntl.c:250:21: note: in expansion of macro 'rcu_dereference' 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~~~~~~~~~~~~~~ In file included from ./arch/x86/include/generated/asm/rwonce.h:1, from include/linux/compiler.h:305, from include/linux/export.h:5, from include/linux/linkage.h:7, from include/linux/fs.h:5: >> fs/fcntl.c:250:50: error: invalid type argument of '->' (have 'struct fown_struct') 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~ include/asm-generic/rwonce.h:44:73: note: in definition of macro '__READ_ONCE' 44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x)) | ^ include/linux/rcupdate.h:527:50: note: in expansion of macro 'READ_ONCE' 527 | typeof(*p) *local = (typeof(*p) *__force)READ_ONCE(p); \ | ^~~~~~~~~ include/linux/rcupdate.h:675:9: note: in expansion of macro '__rcu_dereference_check' 675 | __rcu_dereference_check((p), __UNIQUE_ID(rcu), \ | ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/rcupdate.h:747:28: note: in expansion of macro 'rcu_dereference_check' 747 | #define rcu_dereference(p) rcu_dereference_check(p, 0) | ^~~~~~~~~~~~~~~~~~~~~ fs/fcntl.c:250:21: note: in expansion of macro 'rcu_dereference' 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~~~~~~~~~~~~~~ >> fs/fcntl.c:250:50: error: invalid type argument of '->' (have 'struct fown_struct') 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~ include/linux/rcupdate.h:530:19: note: in definition of macro '__rcu_dereference_check' 530 | ((typeof(*p) __force __kernel *)(local)); \ | ^ include/linux/rcupdate.h:747:28: note: in expansion of macro 'rcu_dereference_check' 747 | #define rcu_dereference(p) rcu_dereference_check(p, 0) | ^~~~~~~~~~~~~~~~~~~~~ fs/fcntl.c:250:21: note: in expansion of macro 'rcu_dereference' 250 | fown_cred = rcu_dereference(filp->f_owner->cred); | ^~~~~~~~~~~~~~~ vim +250 fs/fcntl.c 239 240 #ifdef CONFIG_CHECKPOINT_RESTORE 241 static int f_getowner_uids(struct file *filp, unsigned long arg) 242 { 243 struct user_namespace *user_ns = current_user_ns(); 244 uid_t __user *dst = (void __user *)arg; 245 const struct cred *fown_cred; 246 uid_t src[2]; 247 int err; 248 249 rcu_read_lock(); > 250 fown_cred = rcu_dereference(filp->f_owner->cred); 251 src[0] = from_kuid(user_ns, fown_cred->uid); 252 src[1] = from_kuid(user_ns, fown_cred->euid); 253 rcu_read_unlock(); 254 255 err = put_user(src[0], &dst[0]); 256 err |= put_user(src[1], &dst[1]); 257 258 return err; 259 } 260 #else 261 static int f_getowner_uids(struct file *filp, unsigned long arg) 262 { 263 return -EINVAL; 264 } 265 #endif 266 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
