On Tue, Jun 11, 2024 at 7:20 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Tue, Jun 11, 2024 at 07:17:41AM +0200, Mateusz Guzik wrote: > > > > I agree, but this is me just copying and modifying an existing line. > > > > include/linux/fs.h is chock full of extern-prefixed func declarations, > > on top of that some name the arguments while the rest does not. > > > > Someone(tm) should definitely clean it up, but I'm not interested in > > bikeshedding about it. > > No one asked you to clean the mess up, but don't add any in changed > or added lines. Without that: > > Nacked-by: Christoph Hellwig <hch@xxxxxx> > I am not saying you told me to clean the file up. I am explaining why the addition looks the way it does: I am keeping it consistent with the surroundings, which I assumed is the preferred way. That said, whichever way this is spelled out is fine with me so if vfs overlords want 'extern' removed I will make the change no problem. (or based on what I had seen from Christian so far, he will the touch it up himself, which is again fine with me) -- Mateusz Guzik <mjguzik gmail.com>
