On Tue, Jun 11, 2024 at 07:17:41AM +0200, Mateusz Guzik wrote: > > I agree, but this is me just copying and modifying an existing line. > > include/linux/fs.h is chock full of extern-prefixed func declarations, > on top of that some name the arguments while the rest does not. > > Someone(tm) should definitely clean it up, but I'm not interested in > bikeshedding about it. No one asked you to clean the mess up, but don't add any in changed or added lines. Without that: Nacked-by: Christoph Hellwig <hch@xxxxxx>