On Mon, 15 Apr 2024 11:20:53 -0400, cel@xxxxxxxxxx wrote: > From: Chuck Lever <chuck.lever@xxxxxxxxxx> > > The existing code in shmem_rename2() allocates a fresh directory > offset value when renaming over an existing destination entry. User > space does not expect this behavior. In particular, applications > that rename while walking a directory can loop indefinitely because > they never reach the end of the directory. > > [...] Thanks for fixing this! --- Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/3] libfs: Fix simple_offset_rename_exchange() https://git.kernel.org/vfs/vfs/c/23cdd0eed3f1 [2/3] libfs: Add simple_offset_rename() API https://git.kernel.org/vfs/vfs/c/5a1a25be995e [3/3] shmem: Fix shmem_rename2() https://git.kernel.org/vfs/vfs/c/ad191eb6d694
