On Tue, Apr 09, 2024 at 12:08:23PM +0200, Christian Brauner wrote: > On Fri, 05 Apr 2024 21:40:29 +0000, Günther Noack wrote: > > These IOCTL commands should be implemented by setting attributes on the > > superblock, rather than in the IOCTL hooks in struct file_operations. > > > > By returning -ENOTTY instead of -ENOIOCTLCMD, we instruct the fs/ioctl.c > > logic to return -ENOTTY immediately, rather than attempting to call > > f_op->unlocked_ioctl() or f_op->compat_ioctl() as a fallback. > > > > [...] > > Taking this as a bugfix for this cycle. Looks good. FYI, I added the following tags and re-formated the commit message in my next branch, so it is already in linux-next (but I'll remove it when yours will be merged): https://git.kernel.org/mic/c/5b5c05340e67d1127a3839d1ccb7d7acbb7b9a82 Fixes: 41bcbe59c3b3 ("fs: FS_IOC_GETUUID") Fixes: ae8c51175730 ("fs: add FS_IOC_GETFSSYSFSPATH") You can also add: Acked-by: Mickaël Salaün <mic@xxxxxxxxxxx> > > --- > > Applied to the vfs.fixes branch of the vfs/vfs.git tree. > Patches in the vfs.fixes branch should appear in linux-next soon. > > Please report any outstanding bugs that were missed during review in a > new review to the original patch series allowing us to drop it. > > It's encouraged to provide Acked-bys and Reviewed-bys even though the > patch has now been applied. If possible patch trailers will be updated. > > Note that commit hashes shown below are subject to change due to rebase, > trailer updates or similar. If in doubt, please check the listed branch. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git > branch: vfs.fixes > > [01/12] fs: Return ENOTTY directly if FS_IOC_GETUUID or FS_IOC_GETFSSYSFSPATH fail > https://git.kernel.org/vfs/vfs/c/abe6acfa7d7b >
