On 2024-03-19 16:21:18, Darrick J. Wong wrote: > [fix tinguely email addr] > > On Tue, Mar 19, 2024 at 03:07:43PM -0700, Darrick J. Wong wrote: > > On Mon, Mar 18, 2024 at 09:35:12AM -0700, Eric Biggers wrote: > > > On Sun, Mar 17, 2024 at 09:22:52AM -0700, Darrick J. Wong wrote: > > > > Hi all, > > > > > > > > From Darrick J. Wong: > > > > > > > > This v5.3 patchset builds upon v5.2 of Andrey's patchset to implement > > > > fsverity for XFS. > > > > > > Is this ready for me to review, or is my feedback on v5 still being > > > worked on? > > > > It's still being worked on. I figured it was time to push my work tree > > back to Andrey so everyone could see the results of me attempting to > > understand the fsverity patchset by working around in the codebase. > > > > From your perspective, I suspect the most interesting patches will be 5, > > 6, 7+10+14, 11-13, and 15-17. For everyone on the XFS side, patches > > 27-39 are the most interesting since they change the caching strategy > > and slim down the ondisk format. > > > > > From a quick glance, not everything from my feedback has been > > > addressed. > > > > That's correct. I cleaned up the mechanics of passing merkle trees > > around, but I didn't address the comments about per-sb workqueues, > > fsverity tracepoints, or whether or not iomap should allocate biosets. > > That perhaps wasn't quite clear enough -- I'm curious to see what Andrey > has to say about that part (patches 8, 9, 18) of the patchset. The per-sb workqueue can be used for other fs, which should be doable (also I will rename it, as generic name came from the v2 when I thought it would be used for more stuff than just verity) For tracepoints, I will add all the changes suggested by Eric, the signature tracepoints could be probably dropped. For bioset allocation, I will look into this if there's good way to allocate only for verity inodes, if it's not complicate things too much. Make sense for systems which won't use fsverity but have FS_VERITY=y. -- - Andrey
