Jan,
Commit 082fd1ea1f98 ("fsnotify: optimize the case of no parent watcher")
has reduced the CPU overhead of fsnotify hooks, but we can further
reduce the overhead of permission event hooks, by avoiding the call to
fsnotify() and fsnotify_parent() altogether when there are no permission
event watchers on the sb.
The main motivation for this work was to avoid the overhead that was
reported by kernel test robot on the patch that adds the upcoming
per-content event hooks (i.e. FS_PRE_ACCESS/FS_PRE_MODIFY).
Kernel test robot has confirmed that with this series, the addition of
pre-conent fsnotify hooks does not result in any regression [1].
Kernet test robot has also reported performance improvements in some
workloads compared to upstream on an earlier version of this series, but
still waiting for the final results.
For now, as you requested, I am posting this series for review.
Thanks,
Amir.
[1] https://lore.kernel.org/all/Zc7KmlQ1cYVrPMQ+@xsang-OptiPlex-9020/
[2] https://lore.kernel.org/all/202403141505.807a722b-oliver.sang@xxxxxxxxx/
Amir Goldstein (10):
fsnotify: rename fsnotify_{get,put}_sb_connectors()
fsnotify: create helpers to get sb and connp from object
fsnotify: create a wrapper fsnotify_find_inode_mark()
fanotify: merge two checks regarding add of ignore mark
fsnotify: pass object pointer and type to fsnotify mark helpers
fsnotify: create helper fsnotify_update_sb_watchers()
fsnotify: lazy attach fsnotify_sb_info state to sb
fsnotify: move s_fsnotify_connectors into fsnotify_sb_info
fsnotify: use an enum for group priority constants
fsnotify: optimize the case of no permission event watchers
fs/nfsd/filecache.c | 4 +-
fs/notify/dnotify/dnotify.c | 4 +-
fs/notify/fanotify/fanotify_user.c | 141 +++++++----------------
fs/notify/fsnotify.c | 23 +++-
fs/notify/fsnotify.h | 38 +++++--
fs/notify/inotify/inotify_user.c | 2 +-
fs/notify/mark.c | 173 ++++++++++++++++++++++-------
include/linux/fs.h | 14 +--
include/linux/fsnotify.h | 21 +++-
include/linux/fsnotify_backend.h | 93 +++++++++++-----
kernel/audit_tree.c | 2 +-
kernel/audit_watch.c | 2 +-
12 files changed, 314 insertions(+), 203 deletions(-)
--
2.34.1
