On Tue, Mar 05, 2024 at 03:08:18PM -0600, Bill O'Donnell wrote: > - if ((bool)(*flags & SB_RDONLY) == sb_rdonly(sb)) > + if ((bool)(fc->sb_flags & SB_RDONLY) == sb_rdonly(sb)) > return 0; This is getting really annoying - let's just add static inline bool fc_rdonly(const struct fs_context *fc) { return fc->sb_flags & SB_RDONLY; } and spell the above as if (fc_rdonly(fc) == sb_rdonly(sb)) return 0; etc. Quite a few places have that open-coded...