On Mon, Feb 19, 2024 at 10:34:47AM -0800, Linus Torvalds wrote: > On Mon, 19 Feb 2024 at 10:05, Christian Brauner <brauner@xxxxxxxxxx> wrote: > > > > @Linus, if you're up for it, please take a look at: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.pidfd > > > > The topmost 6 commits contain everything we've had on here. > > Looks ok. The commit message on that last one reads a bit oddly, > because the "Quoting Linus" part looks like it means just the first > quote, even if it's really everything. > > I'd suggest you just not attribute that explanation to me at all, and > edit it down to just a neutral explanation of what is going on. Done. > > But the code itself looks fine, and I like how it just cleaned up the > callers a lot now that they don't have that odd EAGAIN loop thing. Yup. > > I expected that to happen, of course, and it was the point of my > suggestion, but it's still nice to actually see it as a patch that > removes the nasty code rather than just my "I think that's ugly and > could be done differently". I've moved the shared cmpxchg() bit in {ns,pidfs}_prune_dentry() to a tiny helper so the cmpxchg() isn't coded in the open and is documented in a single location. Pushed.
