On Tue, Jan 02, 2024 at 03:41:08PM +0800, Huang, Ying wrote:
> Gregory Price <gregory.price@xxxxxxxxxxxx> writes:
>
> That is, if we use "1" as default weight, we need to change weights of
> nodes frequently because we haven't a "base" weight. The best candidate
> base weight is the weight of DRAM node. For example, if we set the
> default weight of DRAM node to be "16" and use that as the base weight,
> we don't need to change it in most cases. The weight of other nodes can
> be set according to the ratio of its memory bandwidth to that of DRAM.
>
> This makes it easy to set the default weight via HMAT/CDAT too.
>
> What do you think about that?
>
You're getting a bit ahead of the patch set. There is "what is a
reasonable default weight" and "what is the minumum functionality".
The minimum functionality is everything receiving a default weight of 1,
such that weighted interleave's behavior defaults to round-robin
interleave. This gets the system off the ground.
We can then expose an internal interface to drivers for them to set the
default weight to some reasonable number during system and device
initialization. The question at that point is what system is responsible
for setting the default weights... node? cxl? anything? What happens on
hotplug? etc. That seems outside the scope of this patch set.
If you want me to add the default_iw_table with special value 0 denoting
"use default" at each layer, I can do that.
The basic change is this snippet:
```
if (pol->flags & MPOL_F_GWEIGHT)
pol_weights = iw_table;
else
pol_weights = pol->wil.weights;
for_each_node_mask(nid, nodemask) {
weight = pol_weights[nid];
weight_total += weight;
weights[nid] = weight;
}
```
changes to:
```
for_each_node_mask(nid, nodemask) {
weight = pol->wil.weights[node]
if (!weight)
weight = iw_table[node]
if (!weight)
weight = default_iw_table[node]
weight_total += weight;
weights[nid] = weight
}
```
It's a bit ugly, but it allows a 0 value to represent "use default",
and default_iw_table just ends up being initialized to `1` for now.
I think it also allows MPOL_F_GWEIGHT to be eliminated.
~Gregory
