[snip]
> 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 515 if (ret < 0)
{
> 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 516 if
(rw
> & WRITE)
>
> This code works and the checker doesn't complain about it, but for
> consistency I think it should be if (rw == WRITE).
>
> 5f2aa075070cf5b Namjae Jeon 2020-03-02 517
> exfat_write_failed(mapping, size);
> 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 518
> 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 519 if
> (ret != -EIOCBQUEUED)
> 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 520
> return ret;
> 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 521 } else
> 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 522 size
=
> pos + ret;
> 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 523
> 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 524 /* zero the
> unwritten part in the partially written block */
> 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 @525 if ((rw &
READ)
> && pos < ei->valid_size && ei->valid_size < size) {
>
> I think this should be rw == READ.
You're definitely right.
READ is 0, so it always be false.
Dear Yuezhang,
Can you please send v6 again for this?
It would be nice to include fixes for a minor issue reported
by Kernel test robot.
Thanks
