Hi, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yuezhang-Mo-sony-com/exfat-do-not-zero-the-extended-part/20231130-164222 base: linus/master patch link: https://lore.kernel.org/r/PUZPR04MB6316F0640983B00CC55D903F8182A%40PUZPR04MB6316.apcprd04.prod.outlook.com patch subject: [PATCH v5 1/2] exfat: change to get file size from DataLength config: x86_64-randconfig-r081-20231130 (https://download.01.org/0day-ci/archive/20231201/202312010428.73gtRyvj-lkp@xxxxxxxxx/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce: (https://download.01.org/0day-ci/archive/20231201/202312010428.73gtRyvj-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202312010428.73gtRyvj-lkp@xxxxxxxxx/ smatch warnings: fs/exfat/inode.c:525 exfat_direct_IO() warn: bitwise AND condition is false here vim +525 fs/exfat/inode.c 5f2aa075070cf5b Namjae Jeon 2020-03-02 486 static ssize_t exfat_direct_IO(struct kiocb *iocb, struct iov_iter *iter) 5f2aa075070cf5b Namjae Jeon 2020-03-02 487 { 5f2aa075070cf5b Namjae Jeon 2020-03-02 488 struct address_space *mapping = iocb->ki_filp->f_mapping; 5f2aa075070cf5b Namjae Jeon 2020-03-02 489 struct inode *inode = mapping->host; 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 490 struct exfat_inode_info *ei = EXFAT_I(inode); 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 491 loff_t pos = iocb->ki_pos; 5f2aa075070cf5b Namjae Jeon 2020-03-02 492 loff_t size = iocb->ki_pos + iov_iter_count(iter); 5f2aa075070cf5b Namjae Jeon 2020-03-02 493 int rw = iov_iter_rw(iter); 5f2aa075070cf5b Namjae Jeon 2020-03-02 494 ssize_t ret; 5f2aa075070cf5b Namjae Jeon 2020-03-02 495 5f2aa075070cf5b Namjae Jeon 2020-03-02 496 if (rw == WRITE) { 5f2aa075070cf5b Namjae Jeon 2020-03-02 497 /* 5f2aa075070cf5b Namjae Jeon 2020-03-02 498 * FIXME: blockdev_direct_IO() doesn't use ->write_begin(), 5f2aa075070cf5b Namjae Jeon 2020-03-02 499 * so we need to update the ->i_size_aligned to block boundary. 5f2aa075070cf5b Namjae Jeon 2020-03-02 500 * 5f2aa075070cf5b Namjae Jeon 2020-03-02 501 * But we must fill the remaining area or hole by nul for 5f2aa075070cf5b Namjae Jeon 2020-03-02 502 * updating ->i_size_aligned 5f2aa075070cf5b Namjae Jeon 2020-03-02 503 * 5f2aa075070cf5b Namjae Jeon 2020-03-02 504 * Return 0, and fallback to normal buffered write. 5f2aa075070cf5b Namjae Jeon 2020-03-02 505 */ 5f2aa075070cf5b Namjae Jeon 2020-03-02 506 if (EXFAT_I(inode)->i_size_aligned < size) 5f2aa075070cf5b Namjae Jeon 2020-03-02 507 return 0; 5f2aa075070cf5b Namjae Jeon 2020-03-02 508 } 5f2aa075070cf5b Namjae Jeon 2020-03-02 509 5f2aa075070cf5b Namjae Jeon 2020-03-02 510 /* 5f2aa075070cf5b Namjae Jeon 2020-03-02 511 * Need to use the DIO_LOCKING for avoiding the race 5f2aa075070cf5b Namjae Jeon 2020-03-02 512 * condition of exfat_get_block() and ->truncate(). 5f2aa075070cf5b Namjae Jeon 2020-03-02 513 */ 5f2aa075070cf5b Namjae Jeon 2020-03-02 514 ret = blockdev_direct_IO(iocb, inode, iter, exfat_get_block); 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 515 if (ret < 0) { 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 516 if (rw & WRITE) This code works and the checker doesn't complain about it, but for consistency I think it should be if (rw == WRITE). 5f2aa075070cf5b Namjae Jeon 2020-03-02 517 exfat_write_failed(mapping, size); 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 518 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 519 if (ret != -EIOCBQUEUED) 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 520 return ret; 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 521 } else 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 522 size = pos + ret; 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 523 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 524 /* zero the unwritten part in the partially written block */ 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 @525 if ((rw & READ) && pos < ei->valid_size && ei->valid_size < size) { I think this should be rw == READ. 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 526 iov_iter_revert(iter, size - ei->valid_size); 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 527 iov_iter_zero(size - ei->valid_size, iter); 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 528 } 6642222a5afe775 Yuezhang.Mo@xxxxxxxx 2023-11-30 529 5f2aa075070cf5b Namjae Jeon 2020-03-02 530 return ret; 5f2aa075070cf5b Namjae Jeon 2020-03-02 531 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
