Re: [PATCH 3/5] fs: Add DEFINE_FREE for struct inode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Kees Cook <keescook@xxxxxxxxxxxx>
Subject: Re: [PATCH 3/5] fs: Add DEFINE_FREE for struct inode
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Sat, 2 Dec 2023 21:45:02 +0000
Cc: "Guilherme G. Piccoli" <gpiccoli@xxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Tony Luck <tony.luck@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-hardening@xxxxxxxxxxxxxxx
In-reply-to: <20231202214212.GR38156@ZenIV>

On Sat, Dec 02, 2023 at 09:42:12PM +0000, Al Viro wrote:

> I'll poke around and see what I can suggest; said that, one thing I have
> spotted there on the quick look is that you are exposing hashed dentry associated
> with your inode before you set its ->i_private.

... and on the second look, no, you do not do anything of that sort.
My apologies...

References:
- [PATCH 0/5] pstore: Initial use of cleanup.h
  - From: Kees Cook
- [PATCH 3/5] fs: Add DEFINE_FREE for struct inode
  - From: Kees Cook
- Re: [PATCH 3/5] fs: Add DEFINE_FREE for struct inode
  - From: Al Viro
- Re: [PATCH 3/5] fs: Add DEFINE_FREE for struct inode
  - From: Kees Cook
- Re: [PATCH 3/5] fs: Add DEFINE_FREE for struct inode
  - From: Al Viro

Prev by Date: Re: [PATCH 3/5] fs: Add DEFINE_FREE for struct inode
Next by Date: Re: [PATCH 5/5] pstore: inode: Use cleanup.h for struct pstore_private
Previous by thread: Re: [PATCH 3/5] fs: Add DEFINE_FREE for struct inode
Next by thread: Re: [PATCH 3/5] fs: Add DEFINE_FREE for struct inode
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]