Hi, Mostly as practice for myself, I rewrote a bunch of the error handling paths in pstore to use the new cleanup.h routines. Notably, this meant adding a DEFINE_FREE() for struct inode. Notably, I'm enjoying this part: "44 insertions(+), 65 deletions(-)" It also passes basic testing. :) -Kees Kees Cook (5): pstore: inode: Convert kfree() usage to __free(kfree) pstore: inode: Convert mutex usage to guard(mutex) fs: Add DEFINE_FREE for struct inode pstore: inode: Use __free(iput) for inode allocations pstore: inode: Use cleanup.h for struct pstore_private fs/pstore/inode.c | 107 ++++++++++++++++++--------------------------- include/linux/fs.h | 2 + 2 files changed, 44 insertions(+), 65 deletions(-) -- 2.34.1