On Thu 26-10-23 18:52:21, Amir Goldstein wrote: > As agreed on the review of v1 [1], we do not need any vfs changes > to support fanotify on btrfs sub-volumes and we can enable setting > marks on btrfs sub-volumes simply by caching the fsid in the mark > object instead of the connector. > > This is the would be man page update to clarify the meaning of fsid > as it is reflected in this patch set: > > fsid > > This is a unique identifier of the filesystem containing the object > associated with the event. It is a structure of type __kernel_fsid_t > and contains the same value reported in f_fsid when calling > statfs(2) with the same pathname argument that was used for > fanotify_mark(2). Note that some filesystems (e.g., btrfs(5)) report > non-uniform values of f_fsid on different objects of the same filesystem. > In these cases, if fanotify_mark(2) is called several times with different > pathname values, the fsid value reported in events will match f_fsid > associated with at least one of those pathname values. Thanks! The patchset looks good to me but I don't want to queue it now so shortly before the merge window opens. So I'll queue it into my tree once I'll push out changes for the merge window. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
