On Thu, 26 Oct 2023 17:03:35 +0200 Oleg Nesterov <oleg@xxxxxxxxxx> wrote: > On 10/26, Yang Li wrote: > > > > @@ -3826,7 +3826,7 @@ static struct task_struct *first_tid(struct pid *pid, int tid, loff_t f_pos, > > for_each_thread(task, pos) { > > if (!nr--) > > goto found; > > - }; > > + } > > Ah, I forgot to remove this semicolon :/ > > This is on top of > > document-while_each_thread-change-first_tid-to-use-for_each_thread.patch > > perhaps this cleanup can be folded into the patch above along with Yang's sob ? The above is in mainline, so no squashing. I added your acked-by.