On 10/13/23 02:33, Niklas Cassel wrote:
In commit c75e707fe1aa ("block: remove the per-bio/request write hint")
this line from fs/direct-io.c was removed:
- bio->bi_write_hint = dio->iocb->ki_hint;
I'm not sure why this series does not readd a similar line to set the
lifetime (using bio_set_data_lifetime()) also for fs/direct-io.c.
It depends on how we want the user to specify the data lifetime for
direct I/O. This assignment is not modified by this patch series and
copies the data lifetime information from the ioprio bitfield from user
space into the bio:
bio->bi_ioprio = dio->iocb->ki_ioprio;
I still don't understand what happens if one uses io_uring to write
to a file on a f2fs filesystem using buffered-io, with both
inode->i_write_hint set using fcntl F_SET_RW_HINT, and bits belonging
to life time hints set in the io_uring SQE (sqe->ioprio).
Is the documentation of the whint_mode mount option in patch 5/15 of this
series sufficient to answer the above question?
Thanks,
Bart.
