On 9/27/23, Christian Brauner <brauner@xxxxxxxxxx> wrote: >> I don't have a strong opinion, I think my variant is cleaner and more >> generic, but this boils down to taste and this is definitely not the >> hill I'm willing to die on. > > I kinda like the release_empty_file() approach but we should keep the > WARN_ON_ONCE() so we can see whether anyone is taking an extra reference > on this thing. It's super unlikely but I guess zebras exist and if some > (buggy) code were to call get_file() during ->open() and keep that > reference for some reason we'd want to know why. But I don't think > anything does that. > > No need to resend I can massage this well enough in-tree. > Ok, I'm buggering off to other patches. Thanks. -- Mateusz Guzik <mjguzik gmail.com>
