Re: [PATCH] vfs: shave work on failed file open

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Mateusz Guzik <mjguzik@xxxxxxxxx>
Subject: Re: [PATCH] vfs: shave work on failed file open
From: Christian Brauner <brauner@xxxxxxxxxx>
Date: Tue, 26 Sep 2023 16:24:26 +0200
Cc: viro@xxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx
In-reply-to: <CAGudoHG0-BWTVRG8uZk5Gy8xSwpT8JO5Z=VfY3_dFcCaqhLf5Q@mail.gmail.com>

> > if (WARN_ON_ONCE(atomic_long_cmpxchg(&file->f_count, 1, 0) != 1)) {

> bench again.

Can you see how much of a difference it makes because imho it really
looks a lot nicer then this ugly atomic_read followed by atomic_set...

Follow-Ups:
- Re: [PATCH] vfs: shave work on failed file open
  - From: Mateusz Guzik

References:
- [PATCH] vfs: shave work on failed file open
  - From: Mateusz Guzik
- Re: [PATCH] vfs: shave work on failed file open
  - From: Christian Brauner
- Re: [PATCH] vfs: shave work on failed file open
  - From: Mateusz Guzik

Prev by Date: Re: [RFC PATCH 2/3] add statmnt(2) syscall
Next by Date: Re: [PATCH v8 0/5] fs: multigrain timestamps for XFS's change_cookie
Previous by thread: Re: [PATCH] vfs: shave work on failed file open
Next by thread: Re: [PATCH] vfs: shave work on failed file open
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux