> +void fput_badopen(struct file *file)
> +{
> + if (unlikely(file->f_mode & (FMODE_BACKING | FMODE_OPENED))) {
> + fput(file);
> + return;
> + }
> +
> + if (WARN_ON(atomic_long_read(&file->f_count) != 1)) {
> + fput(file);
> + return;
> + }
> +
> + /* zero out the ref count to appease possible asserts */
> + atomic_long_set(&file->f_count, 0);
Afaict this could just be:
if (WARN_ON_ONCE(atomic_long_cmpxchg(&file->f_count, 1, 0) != 1)) {
> + file_free_badopen(file);
> +}
> +EXPORT_SYMBOL(fput_badopen);
Should definitely not be exported and only be available to core vfs
code. So this should go into fs/internal.h.
