On 20/09/2023 15:37, David Sterba wrote: > [...] >> The way I think we could resolve this is by forbidding mounting a >> temp-fsid twice - after the random uuid generation, we could check for >> all fs_devices present and if any of it has the same metadata_uuid, we >> check if it's the same dev_t and bail. >> >> The purpose of the feature is for having the same filesystem in >> different devices able to mount at the same time, but on different mount >> points. WDYT? > > The subvolume mount is a common use case and I hope it continues to > work. Currently it does not seem so as said above, for correctness we > may need to prevent it. We might find more and this should be known or > fixed before final release. > Thanks David, fully agree. And special thanks Anand for unveiling this important flaw. I'll work a small follow-up patch preventing that (will be in conference + travels so that might take some days...) Cheers!