Re: [PATCH v4 07/10] fuse: Remove fuse_direct_write_iter code path / use IOCB_DIRECT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bernd,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mszeredi-fuse/for-next]
[also build test WARNING on linus/master v6.6-rc2 next-20230918]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Bernd-Schubert/fuse-direct-IO-can-use-the-write-through-code-path/20230919-005745
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-next
patch link:    https://lore.kernel.org/r/20230918150313.3845114-8-bschubert%40ddn.com
patch subject: [PATCH v4 07/10] fuse: Remove fuse_direct_write_iter code path / use IOCB_DIRECT
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230919/202309190423.cEQ7h6ai-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230919/202309190423.cEQ7h6ai-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309190423.cEQ7h6ai-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> fs/fuse/file.c:1060: warning: Function parameter or member 'iocb' not described in 'fuse_write_flags'
>> fs/fuse/file.c:1060: warning: expecting prototype for Note(). Prototype was for fuse_write_flags() instead


vim +1060 fs/fuse/file.c

338f2e3f3341a9 Miklos Szeredi 2019-09-10  1054  
abb63dd79fa5c1 Bernd Schubert 2023-09-18  1055  /**
abb63dd79fa5c1 Bernd Schubert 2023-09-18  1056   * Note: iocb->ki_flags & IOCB_DIRECT cannot be trusted here,
abb63dd79fa5c1 Bernd Schubert 2023-09-18  1057   *       it might be set when FOPEN_DIRECT_IO is used.
abb63dd79fa5c1 Bernd Schubert 2023-09-18  1058   */
338f2e3f3341a9 Miklos Szeredi 2019-09-10  1059  static unsigned int fuse_write_flags(struct kiocb *iocb)
338f2e3f3341a9 Miklos Szeredi 2019-09-10 @1060  {
338f2e3f3341a9 Miklos Szeredi 2019-09-10  1061  	unsigned int flags = iocb->ki_filp->f_flags;
338f2e3f3341a9 Miklos Szeredi 2019-09-10  1062  
91b94c5d6ae55d Al Viro        2022-05-22  1063  	if (iocb_is_dsync(iocb))
338f2e3f3341a9 Miklos Szeredi 2019-09-10  1064  		flags |= O_DSYNC;
338f2e3f3341a9 Miklos Szeredi 2019-09-10  1065  	if (iocb->ki_flags & IOCB_SYNC)
338f2e3f3341a9 Miklos Szeredi 2019-09-10  1066  		flags |= O_SYNC;
338f2e3f3341a9 Miklos Szeredi 2019-09-10  1067  
338f2e3f3341a9 Miklos Szeredi 2019-09-10  1068  	return flags;
338f2e3f3341a9 Miklos Szeredi 2019-09-10  1069  }
338f2e3f3341a9 Miklos Szeredi 2019-09-10  1070  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux