On Fri 11-08-23 05:25:41, Christoph Hellwig wrote: > On Fri, Aug 11, 2023 at 01:04:33PM +0200, Jan Kara wrote: > > + blk_mode_t open_mode = ((struct bdev_handle *)file->private_data)->mode; > > Nit: but I find it much more readable to just have a local bdev_handle > variable vs these deep references including casts. This also appears > in a few others places. OK, I've added the local variable to reduce typecasting and the depth of dereferences. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
