Re: [PATCH 02/29] block: Use bdev_open_by_dev() in blkdev_open()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH 02/29] block: Use bdev_open_by_dev() in blkdev_open()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 11 Aug 2023 05:25:41 -0700
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <20230811110504.27514-2-jack@suse.cz>

On Fri, Aug 11, 2023 at 01:04:33PM +0200, Jan Kara wrote:
> +	blk_mode_t open_mode = ((struct bdev_handle *)file->private_data)->mode;

Nit: but I find it much more readable to just have a local bdev_handle
variable vs these deep references including casts.  This also appears
in a few others places.

Follow-Ups:
- Re: [PATCH 02/29] block: Use bdev_open_by_dev() in blkdev_open()
  - From: Jan Kara

References:
- [PATCH v2 0/29] block: Make blkdev_get_by_*() return handle
  - From: Jan Kara
- [PATCH 02/29] block: Use bdev_open_by_dev() in blkdev_open()
  - From: Jan Kara

Prev by Date: Re: [PATCH 03/17] btrfs: call btrfs_close_devices from ->kill_sb
Next by Date: Re: [PATCH v2 0/29] block: Make blkdev_get_by_*() return handle
Previous by thread: [PATCH 02/29] block: Use bdev_open_by_dev() in blkdev_open()
Next by thread: Re: [PATCH 02/29] block: Use bdev_open_by_dev() in blkdev_open()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux