Re: [PATCH v2] attr: block mode changes of symlinks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

one minor nitpick below:

>  	if ((ia_valid & ATTR_MODE)) {
> +		if (S_ISLNK(inode->i_mode))
> +			return -EOPNOTSUPP;

Maybe some of the rationale on why we have this check from the commit
log should go here?




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux