On Wed 05-07-23 15:00:56, Jeff Layton wrote: > In later patches, we're going to change how the inode's ctime field is > used. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > --- > fs/coda/coda_linux.c | 3 ++- > fs/coda/dir.c | 2 +- > fs/coda/file.c | 2 +- > fs/coda/inode.c | 2 +- > 4 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/fs/coda/coda_linux.c b/fs/coda/coda_linux.c > index 903ca8fa4b9b..ae023853a98f 100644 > --- a/fs/coda/coda_linux.c > +++ b/fs/coda/coda_linux.c > @@ -127,7 +127,8 @@ void coda_vattr_to_iattr(struct inode *inode, struct coda_vattr *attr) > if (attr->va_mtime.tv_sec != -1) > inode->i_mtime = coda_to_timespec64(attr->va_mtime); > if (attr->va_ctime.tv_sec != -1) > - inode->i_ctime = coda_to_timespec64(attr->va_ctime); > + inode_set_ctime_to_ts(inode, > + coda_to_timespec64(attr->va_ctime)); > } > > > diff --git a/fs/coda/dir.c b/fs/coda/dir.c > index 8450b1bd354b..1d4f40048efc 100644 > --- a/fs/coda/dir.c > +++ b/fs/coda/dir.c > @@ -111,7 +111,7 @@ static inline void coda_dir_update_mtime(struct inode *dir) > /* optimistically we can also act as if our nose bleeds. The > * granularity of the mtime is coarse anyways so we might actually be > * right most of the time. Note: we only do this for directories. */ > - dir->i_mtime = dir->i_ctime = current_time(dir); > + dir->i_mtime = inode_set_ctime_current(dir); > #endif > } > > diff --git a/fs/coda/file.c b/fs/coda/file.c > index 12b26bd13564..42346618b4ed 100644 > --- a/fs/coda/file.c > +++ b/fs/coda/file.c > @@ -84,7 +84,7 @@ coda_file_write_iter(struct kiocb *iocb, struct iov_iter *to) > ret = vfs_iter_write(cfi->cfi_container, to, &iocb->ki_pos, 0); > coda_inode->i_size = file_inode(host_file)->i_size; > coda_inode->i_blocks = (coda_inode->i_size + 511) >> 9; > - coda_inode->i_mtime = coda_inode->i_ctime = current_time(coda_inode); > + coda_inode->i_mtime = inode_set_ctime_current(coda_inode); > inode_unlock(coda_inode); > file_end_write(host_file); > > diff --git a/fs/coda/inode.c b/fs/coda/inode.c > index d661e6cf17ac..3e64679c1620 100644 > --- a/fs/coda/inode.c > +++ b/fs/coda/inode.c > @@ -269,7 +269,7 @@ int coda_setattr(struct mnt_idmap *idmap, struct dentry *de, > > memset(&vattr, 0, sizeof(vattr)); > > - inode->i_ctime = current_time(inode); > + inode_set_ctime_current(inode); > coda_iattr_to_vattr(iattr, &vattr); > vattr.va_type = C_VNON; /* cannot set type */ > > -- > 2.41.0 > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
