On Wed, Jun 28, 2023 at 08:05:06AM +1000, Dave Chinner wrote: > On Tue, Jun 27, 2023 at 04:15:24PM -0400, Kent Overstreet wrote: > > On Tue, Jun 27, 2023 at 11:16:01AM -0600, Jens Axboe wrote: > > > On 6/26/23 8:59?PM, Jens Axboe wrote: > > > > On 6/26/23 8:05?PM, Kent Overstreet wrote: > > > >> On Mon, Jun 26, 2023 at 07:13:54PM -0600, Jens Axboe wrote: > > > >>> Doesn't reproduce for me with XFS. The above ktest doesn't work for me > > > >>> either: > > > >> > > > >> It just popped for me on xfs, but it took half an hour or so of looping > > > >> vs. 30 seconds on bcachefs. > > > > > > > > OK, I'll try and leave it running overnight and see if I can get it to > > > > trigger. > > > > > > I did manage to reproduce it, and also managed to get bcachefs to run > > > the test. But I had to add: > > > > > > diff --git a/check b/check > > > index 5f9f1a6bec88..6d74bd4933bd 100755 > > > --- a/check > > > +++ b/check > > > @@ -283,7 +283,7 @@ while [ $# -gt 0 ]; do > > > case "$1" in > > > -\? | -h | --help) usage ;; > > > > > > - -nfs|-afs|-glusterfs|-cifs|-9p|-fuse|-virtiofs|-pvfs2|-tmpfs|-ubifs) > > > + -nfs|-afs|-glusterfs|-cifs|-9p|-fuse|-virtiofs|-pvfs2|-tmpfs|-ubifs|-bcachefs) > > > FSTYP="${1:1}" > > > ;; > > > -overlay) > > > > I wonder if this is due to an upstream fstests change I haven't seen > > yet, I'll have a look. > > Run mkfs.bcachefs on the testdir first. fstests tries to probe the > filesystem type to test if $FSTYP is not set. If it doesn't find a > filesystem or it is unsupported, it will use the default (i.e. XFS). > There should be no reason to need to specify the filesystem type for > filesystems that blkid recognises. from common/config: Actually ktest already does that, and it sets $FSTYP as well. Jens, are you sure you weren't doing something funny?