On Mon, Jun 26, 2023 at 07:13:54PM -0600, Jens Axboe wrote: > Doesn't reproduce for me with XFS. The above ktest doesn't work for me > either: It just popped for me on xfs, but it took half an hour or so of looping vs. 30 seconds on bcachefs. > ~/git/ktest/build-test-kernel run -ILP ~/git/ktest/tests/bcachefs/xfstests.ktest/generic/388 > realpath: /home/axboe/git/ktest/tests/bcachefs/xfstests.ktest/generic/388: Not a directory > Error 1 at /home/axboe/git/ktest/build-test-kernel 262 from: ktest_test=$(realpath "$1"), exiting > > and I suspect that should've been a space, but: > > ~/git/ktest/build-test-kernel run -ILP ~/git/ktest/tests/bcachefs/xfstests.ktest generic/388 > Running test xfstests.ktest on m1max at /home/axboe/git/linux-block > No tests found > TEST FAILED doh, this is because we just changed it to pick up the list of tests from the test lists that fstests generated. Go into ktest/tests/xfstests and run make and it'll work. (Doesn't matter if make fails due to missing libraries, it'll re-run make inside the VM where the dependencies will all be available). > As a side note, I do get these when compiling: > > fs/bcachefs/alloc_background.c: In function ‘bch2_check_alloc_info’: > fs/bcachefs/alloc_background.c:1526:1: warning: the frame size of 2640 bytes is larger than 2048 bytes [-Wframe-larger-than=] > 1526 | } > | ^ > fs/bcachefs/reflink.c: In function ‘bch2_remap_range’: > fs/bcachefs/reflink.c:388:1: warning: the frame size of 2352 bytes is larger than 2048 bytes [-Wframe-larger-than=] > 388 | } yeah neither of those are super critical because they run top of the stack, but they do need to be addressed. might be time to start heap allocating btree_trans.
