> > On Jun 22, 2023, at 1:05 PM, stsp <stsp2@xxxxxxxxx> wrote: > > > > > > 22.06.2023 21:58, Chuck Lever III пишет: > >> IMO that's not a reason not to do this properly. > >> > >> You should work with Jeff and the maintainer of xfstests to make it > >> happen. > > But its not going to be in this patch-set anyway, as its a different > > source tree... > > If others agree with me, then please drop the selftests patch from this series. > There is a considerably higher probability that the new test will be run frequently > by CI if it's in xfstests. > > > > So I should prepare it when this is merged, or? > > I don't have a strong preference. A good choice is to push the test before the > kernel changes are merged. As an aside, an additional testing option for OFD locks is the multilock test tool that is in the nfs-ganesha project. In preparation to use OFD locks in Ganesha, I added them to multilock to check them out, and that incidentally also allows testing how the NFS client and server work when OFD locks are taken on a file from an NFS mount. Frank